Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • KWin KWin
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 58
    • Issues 58
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 160
    • Merge requests 160
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • KWinKWin
  • Merge requests
  • !3274

kcms/rules: Notify when a window does not provide a class

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ismael Asensio requested to merge work/iasensio/rules-notify-rogue-app into master Dec 05, 2022
  • Overview 4
  • Commits 3
  • Pipelines 6
  • Changes 4

Some applications do not provide a window class according to the spec (WM_CLASS on X11, appId on Wayland), so KWin cannot "detect" this property.

In those cases, notify the user that this is a bug within the application (so it is not confused for a KWin misbehavior), and also prevent setting a wrong description.

BUG: 462644 FIXED-IN: 5.27

rules-error-noclass

Previous commits are to improve the visuals of the error message with larger texts and use the proper Kirigami.Dialog instead of an overlay sheet.

Kirigami.OverlaySheet Kirigami.Dialog
rules-error-overlay rules-error-unmanaged
Edited Dec 06, 2022 by Ismael Asensio
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/iasensio/rules-notify-rogue-app