Skip to content

tabbox: Remove Xcb::sync()

Vlad Zahorodnii requested to merge work/zzag/tabbox-xcb-sync into master

TabBox::hide() used to contain the following code

QApplication::syncX();
XEvent otherEvent;
while (XCheckTypedEvent(display(), EnterNotify, &otherEvent))
    ;

The purpose of XSync() is to flush any pending requests and wait until the X server processes them. After that, we can go through event queue to find relevant events.

Why did tabbox go through the event queue to find the EnterNotify events? It's unclear. So it was removed in b4c957b6. However, the XSync() call was left out. It doesn't make sense on its own. So remove it too.

Merge request reports