Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • KWin KWin
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 60
    • Issues 60
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 164
    • Merge requests 164
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • KWinKWin
  • Merge requests
  • !3417

kcms/tabbox: Make shortcuts config save on apply

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ismael Asensio requested to merge work/iasensio/config-tabbox-shorcuts into master Jan 11, 2023
  • Overview 11
  • Commits 1
  • Pipelines 11
  • Changes 3

Currently, tabbox shortcuts are directly saved to KGlobalAccel when they change, which is inconsistent with the rest of the KCM and leads to confusion regarding Defaults and isSaveNeeded stats.

Let's instead manage the changes internally and just save them to KGlobalAccel on Apply/Save.

m_actionsCollection is only used as a helpful way to store this internal configuration, and doesn't really needs saving to or restoring from config.

BUG: 459325 FIXED-IN: 5.27

Please, test thoroughly. I've might have messed up my own KGlobalAccel shortcuts while debugging this 😄

Edited Jan 11, 2023 by Ismael Asensio
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/iasensio/config-tabbox-shorcuts