Skip to content

screenedge: don't reduce approachGeometry

Yifan Zhu requested to merge work/fanzhuyifan/edge-effect into master

Reducing approachGeometry is not needed.

During edge creation, createHorizontalEdge and createVerticalEdge already substract the needed cornerOffset, and edges reserved by client windows shouldn't be reduced in geometry. In addition, during display, ScreenEdgeEffect confines the painted area to approachGeometry. So approachGeometry shouldn't be reduced in advance.

BUG: 481282

@teams/qa I tested this on both X11 and wayland, for both edges with actions, and edges created by hidden panels. In all cases this makes the edge effect correspond with where the edge actually activates. I don't know why reducing approachGeometry was needed in the past.

Edited by Yifan Zhu

Merge request reports