Skip to content

[kcm/kwinrules] Fix detection of wmclass property

Ismael Asensio requested to merge work/fix_wmclass into Plasma/5.19

Property wmclass of a window rule works in a special way, as it can have two meanings depending on wmclasscomplete flag:

  • false: only matches resourceClass
  • true: matches resourceName and resourceClass

This MR fixes two subtle bugs when detecting the properties of a window:

In the first case, resourceName was being wrongly set instead, which prevented window matching for windows where those two values differ.

Also, the wmclass field was always set to resourceName independently of wmclasscomplete property.

BUG: 423138 CCBUG: 423214 FIXED-IN: 5.19.3

Edited by Ismael Asensio

Merge request reports