Skip to content

Remember if an output ever had a brightness device assigned

Jakob Petsovits requested to merge work/jpetso/brightness-device-ever-assigned into master

Addresses #238 (closed).

PowerDevil or other external brightness device providers can remove a brightness device after it has been added to an output. This can happen e.g. if DDC/CI errors prevent communication with a monitor.

Prior to this commit, KWin would keep using the output's last known brightness value, but use it for software brightness instead. If the output's hardware brightness is merely inaccessible but otherwise unchanged, a 50% brightness value would then imply an actual brightness of 50% hardware * 50% software = 25%. This is confusing and generally undesirable.

This commit works around the situation by only allowing software brightness controls if no external brightness device was ever assigned to an output. This will take away all brightness controls from users whose hardware brightness controls have stopped working. That's still better than suddenly changing how the controls work, though.

Edited by Jakob Petsovits

Merge request reports