Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • KWin KWin
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 67
    • Issues 67
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 161
    • Merge requests 161
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • KWinKWin
  • Merge requests
  • !819

wayland: Port DebugConsole away from SubSurfaceMonitor

  • Review changes

  • Download
  • Patches
  • Plain diff
Open Vlad Zahorodnii requested to merge work/debug-console-port-from-subsurface-monitor into master Apr 01, 2021
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 2

SubSurfaceMonitor was created with a goal to avoid re-computing the window geometry when the sub-surface tree changes. However, over the time, its usage spreaded beyond XdgSurfaceClient.

At one point, the scene was using the SubSurfaceMonitor helper and it showed that it is not a good abstraction. In case of the scene, letting surface items monitor sub-surface tree changes is a much better idea. Unfortunately, the SubSurfaceMonitor helper only hides unfortunate design decisions.

Since the effective window geometry should not change dynamically [1], we don't need to monitor sub-surface trees in XdgSurfaceClient.

Given that, as the first step towards removal of the SubSurfaceMonitor class, this change makes the debug console monitor sub-surface trees manually.

[1] https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/54

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/debug-console-port-from-subsurface-monitor