Skip to content

Task animations #5

Martijn Vogelaar requested to merge aeropto/latte-dock:taskAnimations into master

As previously said here is the MR for the animations.

What I've done is the following:

I've tried to make as little changes to the existing code as possible. The "core" / "visible" animation from both the LauncherAnimation and NewWindowAnimation are removed. The visible animation is now dynamically loaded depending on the chosen animation. All currently available animations are located in the folder: TaskAnimations. Due to the fact that these are dynamically loaded in the already existing LauncherAnimation and NewWindowAnimation all these animations contain rather little logic and are purely animations. I've tried to take your concerns about breaking stuff into account and in my eyes by using this approach I've minimized the chances of breaking stuff since there is practically no logic in the animation itself.

Regarding your concern about maintaining the animations: as far as I can see the current approach isn't error-prone but if any bugs come up down the road I'll take responsibility to fix them.

Edited by Martijn Vogelaar

Merge request reports

Loading