Skip to content

Grid Face: Fix sizing of compact representation

Arjen Hiemstra requested to merge work/ahiemstra/facegridsize into master
  • faces/grid: Add an icon for the face

Don't know why we never set one

  • faces/grid: Hide individual faces if they are out of bounds

This prevents ugly overflow issues in popups and panels.

  • faces/grid: Use CompactSensorFace for the compact rep

Going against my own comment, as it turns out that the size hints from FaceGrid are not as useful as I hoped and are not really fixable either. So instead just follow the general sizing hints we set up for compact reps, with a slight tweak to the minimum size to account for the grid.

BUG: 489307

  • faces/grid: Propagate all size hints from FaceControl

Instead of only the minimum size. This allows us to use the other size hints properly.

Merge request reports