Skip to content

containmentitem.cpp: Do not set dropJob parent to m_dropMenu

Akseli Lahtinen requested to merge work/akselmo/dont-reparent-dropjob into master

Setting the parent of dropJob to m_dropMenu here can cause crashes, due to m_dropMenu not necessarily existing. For example in cases where one drags an item from task manager that has no associated desktop file, the m_dropMenu is deleted, which deletes the job during async operation/running a method (line 423), which then causes crashing.

BUG:484674

Edited by Akseli Lahtinen

Merge request reports

Loading