Skip to content

Rename C++ class ToolTip to ToolTipArea to match QML naming

ivan tkachenko requested to merge work/r/optimal-timer into master

Rename C++ class ToolTip to ToolTipArea to match QML naming

It is very confusing to have classes and files named differently, and it breaks text-based Go To navigation. This is a public/exported class, so we are free to rename it as we will.


other little things:

ToolTip & ToolTipDialog: Put the QTimer object inline

This saves us from an extra indirect access, and doesn't require parent-child object relationship to keep track of objects lifetimes, so overall it is slightly more efficient.

ToolTipDialog: Make connect() and disconnect() calls consistent

There is no reason to call the getter method multiple times. Besides, the compiler might not be able to infer that the value hasn't changed in order to apply any optimizations.

Fix typo in comment

Merge request reports

Loading