Skip to content

Only remove shortcuts on applet removal not destruction

David Edmundson requested to merge work/shortcut into master

Applets are destroyed every time we close plasma as well as user actions.

We only want to remove the shortcut from the registry from when an applet is actually removed.

The end-user impact was limited as when we restart plasma we re-register and plasma keeps it's own cache of what the shortcut should be so it doesn't matter that kglobalaccel lost it's version.

The problem is that it means we send bogus calls to kglobalaccel after kglobalaccel is potentially closed.

Testing done:

  • set a shortcut on an applet
  • confirmed it still worked after plasma restart
  • removed an applet (and closed notificaiton so it wasn't in the transient state)
  • confirmed the entry was gone from system settings and the global shortcut no-opped.

Merge request reports