Skip to content

dataengine: do not emit removal signals while iterators are open

Harald Sitter requested to merge work/sitter/kf5-dataengine-mpris-crash into kf5

this likely caused connect-based call chains into client code that would then mutate the underlying container such that the iterator goes invalid mid-removal resulting in a crash.

to solve this simply emit the signals all in one go initially, before iterating the sources for removal

BUG: 446531

(only applicable to kf5 since dataengine appears removed in master)

Merge request reports

Loading