Skip to content

Add toolbar badge when there's a player on a page

Kai Uwe Broulik requested to merge work/player-toolbar into master

Makes it more obvious that the extension now offers settings to disable controls on this page.

BUG: 435470


@ngraham @fvogt @davidre

  • Started a video in an overlay, got a badge
  • Closed video overlay, badge was removed
  • Navigated away, badge was removed – this is a browser feature where adding calling setBadgeText with a tabId will pin it to that specific page and remove it automatically when page is reloaded, unloaded, navigated away, etc

It takes precedence over the host crash exclamation mark, but I verified that when there is no player, the badge is reset to global default (hence null, only found out in Firefox docs that this is how to reset it…) and will show the exclamation mark again.

Firefox:

Screenshot_20210416_132506

Chrome

Screenshot_20210416_132458

Edited by Kai Uwe Broulik

Merge request reports

Loading