Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Plasma Desktop Plasma Desktop
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 25
    • Issues 25
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 45
    • Merge requests 45
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma DesktopPlasma Desktop
  • Merge requests
  • !1325

kcms/keys: add a "Choose" button to command adding sheet

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nate Graham requested to merge ngraham/plasma-desktop:add-choose-script-button into master Jan 07, 2023
  • Overview 5
  • Commits 1
  • Pipelines 4
  • Changes 3

This makes it easier for users to choose script files, so they don't have to type out the full path themselves, which is error-prone.

Some code is adjusted accordingly; for example to make addCommand() accept URLs (which are what the file dialog gives us) and convert them to local paths, increase the dialog width to accommodate a new button, and rename an existing dialog to make its purpose clear, now that there are two dialogs.

There is no error-checking to make sure that the script file exists, doesn't live at a remote location, is executable, and has a shebang. But those are all pre-existing issues and will be fixed in another MR, probably copying code from the autostart KCM which handles these cases.

Testing done

Tested to make sure that these use cases still worked:

  • Add raw command to the text field
  • Type local file path into the text field
  • Type URL into the text field
  • Use the open dialog to select a file

image

@bharadwaj-raju @teams/usability @teams/vdg

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: add-choose-script-button