Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Plasma Desktop Plasma Desktop
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 25
    • Issues 25
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 45
    • Merge requests 45
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma DesktopPlasma Desktop
  • Merge requests
  • !1336

window-list: Add fallback icons

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Guilherme Marçal Silva requested to merge raploz/plasma-desktop:wl_fallback into master Jan 13, 2023
  • Overview 16
  • Commits 8
  • Pipelines 10
  • Changes 2

Currently, the Window List applet will show an empty icon when focused on the desktop, meaning the button becomes invisible when it's set to only show icons (or on a vertical panel). It also doesn't show any icon if an application refers to an invalid icon (eg. An icon that can't be found on the disk).

Before:

Window list on the desktop Panel (Plasma Desktop) Panel (App with invalid icon) Icon-only mode with invalid icon or when focused on the Desktop
desktop_nofallback barnofallback barnofallbackapp barnofallbackemptyicononly

After:

Window list on the desktop Panel (Plasma Desktop) Panel (App with invalid icon) Icon-only mode with invalid icon or when focused on the Desktop
desktopfallbackicon image fallbackiconapp fallbackicononlyapp image

Btw, there's no fallback icon on the window list itself that appears when you click the windowlist button on the panel. I think taskmanager provides the icons there for all task switchers, so changing that is outside the scope of this merge request.

@teams/vdg

Edited Jan 16, 2023 by Guilherme Marçal Silva
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wl_fallback