Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Plasma Desktop Plasma Desktop
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 31
    • Issues 31
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 58
    • Merge requests 58
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma DesktopPlasma Desktop
  • Merge requests
  • !1490

landingpage: Fix "Most Used Pages" grid

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged ivan tkachenko requested to merge work/ratijas/land into master Apr 26, 2023
  • Overview 8
  • Commits 5
  • Pipelines 2
  • Changes 2

landingpage: Set implicit size, so that kcmshell doesn't open too small

landingpage: Clean up a comment

ButtonGroup is good, ButtonGroup is needed, leave ButtonGroup alone.

landingpage: Clean up unused function

landingpage: Fix broken binding in "Most Used Pages" grid

First rule of the fighting club: never bind to a list. You never know what the heck you're up against.

On the other hand, assigning FormData.buddyFor in a procedural way in the Repeater's hook is robust, and there's nothing that could go wrong.

CCBUG: 468712

landingpage: Port "Most Used Pages" grid to Kirigami.SizeGroup

Even though SizeGroup is unpolished and to-be-redone, it is still better than hand-rolled implementation of O(n^2/2) custom property watcher.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/ratijas/land