Skip to content

kcms/mouse: Explicit build options for Wayland and X11 backends

Jakob Petsovits requested to merge jpetso/plasma-desktop:work/jpetso/kcm_mouse-explicit-cmake-options into master

KDE prefers explicit CMake options over a conditional build that depends on which headers are installed on the user's system. Two new options are introduced to turn the build for the X11 and KWin+Wayland backends on or off separately.

The mouse KCM will now build both backends by default, as before, but won't silently exclude kcm_mouse from the build if any of its required xorg-evdev/xorg-libinput/X11_Xi/X11_Xinput dependencies are missing. Instead, it will loudly fail CMake configuration with an error and a hint about the existence of the CMake option.

This is the sister MR to !1616 (merged), which does the same thing for kcm_touchpad. Either can be merged independently, although this will cause a tiny amount of conflict resolution.

I see that the CI pipeline fails on both FreeBSD and SUSE Tumbleweed. Given that I didn't change any of the X11 checks (just moved them around), this would indicate that the kcm_mouse build was silently omitted for both CI jobs. Either the checks were already incorrect, and need to be fixed independently so the X11 build on those platforms can go ahead, or -DBUILD_KCM_MOUSE_X11=OFF must now be added to the CMake options for those CI builds.

Merge request reports