Skip to content

applets/taskmanager

ivan tkachenko requested to merge work/r/taskmanager into master

Explicitly specify arguments in signal handlers

Injection of parameters into signal handlers is deprecated. Use JavaScript functions with formal parameters instead.

Minor code style fixes and improvements

Such as using strict === equality operator, adding type hints to method arguments and return values, porting var to const/let, marking properties as readonly, and replacing regular functions with lightweight arrow functions.

Reverts pointless indentation changes introduced in commit e602248f

Drop QML import versions

They are deprecated and unhelpful.

This is an automated change using the following regexp: Search: (import \S+) \d\S*( as \S*)? Replace: \1\2

Remove unused imports

In Qt 6 importing QtQml is no longer required to fix the Binding enum. And QtQuick.Window is now nothing but an alias to QtQuick.

Use conventional import aliases

Use proper data structure for a set of matches

Port ScrollableTextWrapper to explicit and required content property

Default properties are weird when used for non-list singular types.

Also, let's drop the bindings with default values, and move parent & width management inside the ScrollableTextWrapper component because that's what should be doing.

Use registered type for Mpris.PlayerContainer property

Requires plasma-workspace!4325 (merged)

Remove unused property GroupDialog::overflowing

Amends 85d58008

Backend: Optimize check for list's emptiness

Port from Qt.createQmlObject to Qt.createComponent

This new overload allows specifying module URI and a type name, which is way better than parsing some QML sources at runtime.

Improve some property types

In places where we can't document the type formally, at least add an inline comment with the actual type's name. That's the best we can do.

Port ToolTip to pragma ComponentBehavior: Bound

This patch gets rid of lots of context property lookups.

Be careful when testing with activities subtext feature, because it was a complete mess with things like empty list and undefined value potentially being treated differently, or identical statements in complementary code paths of conditional branches.

Fix subtext label inappropriately eliding

This label may have up to 2 lines of text: one for virtual desktops, and another for activities. With the restriction of 1 line max, it may weirdly elide at the end of the first line even though there may be more than enough space for more text; my first thought was that something restricts the width of the label, but it turned out that the height is the one being restricted.

Test plan:

  • Create more than one activity;
  • Create more than one virtual desktop;
  • Open Task Manager's configuration, switch to Behavior tab, and make sure that "Show only tasks" is...
    • From current desktop <- is unchecked
    • From current activity <- checked
  • Open any normal window, like Dolphin or Kate, right click its title (decorations) or Alt+F3, and assign it to multiple virtual desktops and activities.
  • Hover over your application's icon in the Task Manager

Make sure that in the popup there are two lines of text:

  • "On %virutal desktop name%" and
  • "Also available on %activity name%"

Merge request reports