Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Plasma Desktop Plasma Desktop
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 31
    • Issues 31
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 60
    • Merge requests 60
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma DesktopPlasma Desktop
  • Merge requests
  • !242

WIP: [kcm_clock] Prevent error when NTP is disabled

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Jan Paul Batrina requested to merge jbatrina/plasma-desktop:ntp-disable-error-fix into master Nov 24, 2020
  • Overview 7
  • Commits 1
  • Pipelines 0
  • Changes 2

In timedated_interface.h, SetNTP() and SetTime() use asyncCallWithArgumentList and the error happens when SetTime somehow takes effect before SetNTP does.

This fixes the issue (Tested by spamming enable/disable "Set date and time automatically"), but I'm not sure if an infinite loop is 100% impossible.

see !242 (comment 141636)

BUG: 429112

Edited Nov 26, 2020 by Jan Paul Batrina
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: ntp-disable-error-fix