Skip to content

kcms/touchpad: use attached tooltips and tweak text

Christoph Wolk requested to merge cwo/plasma-desktop:touchpad_tooltips into master

The touchpad kcm uses a lot of tooltips; in contrast to most other kcms these tooltips use full ToolTip objects instead of the ToolTip attached property, which is more memory-efficient as all tooltips can use the same object and makes it more convenient to browse multiple tooltips as it is no longer always necessary to wait for the tooltip delay if a tooltip is already open. The tooltip delay is also hardcoded to 1 second, rather than reading the common unit in Kirigami.Units. Some of the wordings are also unclear, grammatically awkward, or inconsistent with each other.

This change switches the ToolTip objects to the ToolTip attached property, sets the delay to use the one in Kirigami.Units, and tweaks the tooltip texts. The touched lines (and a few others where it seemed helpful) also have their translation context added or expanded.

I didn't originally intend to do so many non-trivial string changes, or I would have split those out in a separate commit. Here's a list of (what should be) all the non-trivial changes for easy viewing:

before after reason
Disable touchpad while typing to prevent accidental inputs. Disable touchpad while typing to prevent accidental pointer movement or clicks "inputs" is awkward; makes it more explicit
Pressing the left and right button simultaneously acts as middle-click. Simultaneously pressing the left and right button acts as middle-click. Consistency ('simultaneously' always in front of verb, avoids syntactic ambiguity)
Slide with two fingers scrolls. Slide with two fingers to scroll. Consistency/awkward grammar; use "to X" for user-intended effect
Slide on the touchpad edges scrolls. Slide on the edges of the touchpad to scroll. Consistency/awkward grammar; use "to X" for user-intended effect
Touchscreen like scrolling. Scroll like on a touchscreen. For example, sliding up scrolls down as if pushing a physical object. Spelling; make it more explicit
Sliding over touchpad directly after tap drags. Tap then immediately slide on the touchpad to drag the tapped item. Awkward grammar, more explicit
Dragging continues after a short finger lift. Continue dragging items even if the finger briefly leaves the touchpad, for example to reposition the finger. Awkward grammar, more explicit
Tap with two fingers to right-click, tap with three fingers to middle-click. Tap with two fingers to right-click. Tap with three fingers to middle-click. Wrong punctuation/run-on sentence; use simple sentence construction
Tap with two fingers to middle-click, tap with three fingers to right-click. Tap with two fingers to middle-click. Tap with three fingers to right-click. Wrong punctuation/run-on sentence; use simple sentence construction
Pressing the bottom right corner of your touchpad acts as right-click. […] Pressing the bottom right corner of the touchpad acts as right-click. Consistency - always the thouchpad, never "your"
Pressing the bottom right corner of your touchpad acts as right-click. Pressing the bottom middle edge of the touchpad acts as middle-click. Oversight in previous MR; consistency - always the thouchpad, never "your"
Pressing the bottom left and bottom right corners simultaneously acts as middle-click. Simultaneously pressing the bottom left and bottom right corners acts as middle-click. Consistency ('simultaneously' always in front of verb, avoids syntactic ambiguity)

Merge request reports