Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Plasma Desktop Plasma Desktop
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 26
    • Issues 26
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 43
    • Merge requests 43
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma DesktopPlasma Desktop
  • Merge requests
  • !278

Fix size on not skinny vertical panels

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nate Graham requested to merge ngraham/plasma-desktop:fix-size-on-not-skinny-vertical-panels into master Dec 23, 2020
  • Overview 1
  • Commits 2
  • Pipelines 0
  • Changes 1

[folder view] de-duplicate switch width/height logic


[folder view] Fix display on not-skinny vertical panels

Folder view has some logic to switch between its compact and full representations for vertical panels, but it is faulty, and causes the switch to happen at approximately 50px width. At this width, the display is completely unusable as the text is elided away into nothingness.

This commit remedies the situation by imposing a more sane minimum width based on gridUnit. With the default 10pt font, the minimum thickness is now 144px, which leaves enough room for the labels to be at least partially visible. At lower panel widths, the applet displays its compact representation.

BUG: 406806 FIXED-IN: 5.18.7

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-size-on-not-skinny-vertical-panels