Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Plasma Desktop
Plasma Desktop
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3
    • Issues 3
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 43
    • Merge Requests 43
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Plasma
  • Plasma DesktopPlasma Desktop
  • Merge Requests
  • !294

Merged
Opened Jan 12, 2021 by Nate Graham@ngraham🔩Developer

[kcms/keyboard] Use correct color for layout label in KCM

  • Overview 3
  • Commits 1
  • Changes 4

The label was always using the text color from the Plasma theme, which just happened to work fine as long you were using the same colors for both your Plasma and Apps colors (e.g. both dark or both light). But when using one dark and the other light, the text would become invisible.

This is resolved by adding a paremeter to the function that allows it to specify whether it should get its text color from the Plasma theme or apps color scheme. Then the function invocation for the tray item asks for the Plasma theme color and the invocation in the KCM asks for the apps color scheme color.

Now the label is always visible:

Screenshot_20210112_111438

BUG: 431361 FIXED-IN: 5.21

Edited Jan 12, 2021 by Nate Graham
Assignee
Assign to
Reviewer
Request review from
5.21
Milestone
5.21
Assign milestone
Time tracking
Reference: plasma/plasma-desktop!294
Source branch: fix-keyboard-kcm-layout-color