Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Plasma Desktop
Plasma Desktop
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3
    • Issues 3
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 43
    • Merge Requests 43
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Plasma
  • Plasma DesktopPlasma Desktop
  • Merge Requests
  • !298

Merged
Opened Jan 15, 2021 by Nicolas Fella@nicolasfellaDeveloper

[kcm/users] Avoid half transactions when user cancels auth dialog

  • Overview 2
  • Commits 1
  • Changes 2

Not all calls to accountsservice require authentication and once we hit one that does and the user cancels the prompt then there might be some fields written already. This is unexpected for the user since they expect the whole transaction to be cancelled.

To avoid this move the call to SetAccountType to the front since that will always trigger a prompt.

It's arguably a workaround for the lack of a transaction concept in AccountsService, but I don't see a better short-term solution.

BUG: 425036

Assignee
Assign to
Reviewer
Request review from
5.21
Milestone
5.21
Assign milestone
Time tracking
Reference: plasma/plasma-desktop!298
Source branch: work/accounttransaction