Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Plasma Desktop Plasma Desktop
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 10
    • Issues 10
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 47
    • Merge requests 47
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • Plasma DesktopPlasma Desktop
  • Merge requests
  • !460

Merged
Created May 11, 2021 by Nate Graham@ngrahamDeveloper

[kcms/keys] Port sidebar list item to Kirigami.BasicListItem

  • Overview 11
  • Commits 1
  • Changes 1

Requires frameworks/kirigami!290 (merged)

This commit ports the Shortcuts KCM's sidebar list items to use Kirigami.BasicListItem, which fixes a binding loops and some bugs related to incorrect colors caused by the custom content item, and gets rid of another bespoke list item implementation. The embedded hover ToolButtons are changed to regular Buttons to avoid losing their hover appearance entirely due to differences in BasicListItem's coloration semantics.

The result has minor visual differences but is functionally the same.

Screenshot_20210510_210448

cc @teams/vdg @davidre

BUG: 436816 FIXED-IN: 5.23

Edited May 11, 2021 by Nate Graham
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: port-kcm-keys-to-basiclistitem