[kcms/keys] Port sidebar list item to Kirigami.BasicListItem (!460) · Merge requests · Plasma / Plasma Desktop

Nate Graham requested to merge ngraham/plasma-desktop:port-kcm-keys-to-basiclistitem into master May 11, 2021

Requires frameworks/kirigami!290 (merged)

This commit ports the Shortcuts KCM's sidebar list items to use Kirigami.BasicListItem, which fixes a binding loops and some bugs related to incorrect colors caused by the custom content item, and gets rid of another bespoke list item implementation. The embedded hover ToolButtons are changed to regular Buttons to avoid losing their hover appearance entirely due to differences in BasicListItem's coloration semantics.

The result has minor visual differences but is functionally the same.

cc @teams/vdg @davidre

BUG: 436816 FIXED-IN: 5.23

Edited May 11, 2021 by Nate Graham

[kcms/keys] Port sidebar list item to Kirigami.BasicListItem

Merge request reports