Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Plasma Desktop Plasma Desktop
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 25
    • Issues 25
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 49
    • Merge requests 49
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma DesktopPlasma Desktop
  • Merge requests
  • !494

[taskmanager] Fix previously-hovered windows getting highlighted on Wayland

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Bharadwaj Raju requested to merge bharadwaj-raju/plasma-desktop:highlight-wayland-containsmouse-fix into master Jun 09, 2021
  • Overview 11
  • Commits 2
  • Pipelines 0
  • Changes 1

On Wayland, if user clicks to activate a window in the tooltip, then opens the tooltip again, the ToolTipWindowMouseArea still thinks containsMouse is true, so the highlight is displayed again even though the mouse isn't actually hovering over the thumbnail, just over the icon.

Instead, we now use onPositionChanged which will only fire when the user really moves their mouse over the thumbnail.


I suspect using the positionChanged signal might be a bit less performant than containsMouseChanged? It would be better to make the MouseArea always have the true value of containsMouse, but I haven't found any way to do that. This solution is a bit hacky.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: highlight-wayland-containsmouse-fix