Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Plasma Desktop Plasma Desktop
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 25
    • Issues 25
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 45
    • Merge requests 45
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma DesktopPlasma Desktop
  • Merge requests
  • !557

kcms/landingpage: Don't show feedback UI at all if disabled

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Nate Graham requested to merge ngraham/plasma-desktop:user-feedback into master Sep 07, 2021
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 2

It's possible for the user feedback C++ module to be installed but disabled, or for its QML module to not be installed. In this situation, the UI just looks broken. Instead let's not show it at all.

BUG: 438482 BUG: 439220 FIXED-IN: 5.23

Note that both relevant bug reports are from Neon, so it's possible that this is a Neon Packaging bug that we should fix instead of working around here. cc @jriddell @sitter @apol

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: user-feedback