Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Plasma Desktop Plasma Desktop
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 11
    • Issues 11
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 40
    • Merge requests 40
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • Plasma DesktopPlasma Desktop
  • Merge requests
  • !814

foldermodel: hide undo action when it's not available

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Nate Graham requested to merge ngraham/plasma-desktop:hide-undo-action-when-not-available into master Jan 21, 2022
  • Overview 6
  • Commits 1
  • Pipelines 2
  • Changes 1

This action appears only in the context menu, and context menus are inherently contextual: they should only show things relevant to what was right-clicked. Therefore it never makes sense to have disabled items in a context menu; they should be hidden instead.

This commit does that for the Undo action, only showing it in the context menu when it is contextually relevant.

cc @teams/usability


The desktop context menu now has one less item in it by default. Obviously the undo action will appear when relevant, but at all other times it will be hidden, like so:

Without_undo_action

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: hide-undo-action-when-not-available