Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Firewall
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma Firewall
  • Merge requests
  • !47

Allow IP addresses with netmask in advanced rule editor

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Daniel Vrátil requested to merge work/ip-netmask into master Jun 21, 2022
  • Overview 17
  • Commits 1
  • Pipelines 7
  • Changes 8

Especially for firewall configuration, it's very much useful to be able to allow or block subnets (e.g. I want to allow all traffic originating on trusted part of my home network). Both UFW and firewalld to accept IP addresses with netmask, so it is just about allowing them in the input's validtors.

I decided to replace the regular expressions with a custom QValidator subclass, which uses lib'c inet_pton() to validate the entered IP address and can also handle optional netmasks.

FEATURE: 434317 CHANGELOG: Allow IP addresses with netmask in advanced rule editor

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/ip-netmask