Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Plasma Mobile Plasma Mobile
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 67
    • Issues 67
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma MobilePlasma Mobile
  • Merge requests
  • !145

Rework top panel

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Devin Lin requested to merge work/rework-top-panel into master Mar 28, 2021
  • Overview 19
  • Commits 20
  • Pipelines 0
  • Changes 20

Rework the top panel to be smoother and more consistent feeling, as well as updating the appearance based on this mockup:

image

Changes:

  • Refactor the panel containment so that it is easier for new contributors to understand the code
  • Fix all binding loops
  • Use clip in order to prevent delegates from showing outside of the quicksettings panel
  • Cap first swipe to just showing the pinned
  • Rework colours to be more vibrant, and don't use opacity on quicksettings panel
  • Add shadowed rectangle footer on quicksettings panel to be similar to the lockscreen (it also looks nicer imo)

WIP (oops):

  • The quicksettings delegates expanding widths as they go from pinned -> full height causes infinite binding loops jumping every~where (currently disabled)
  • For some reason the notifications panel no longer shows up 😭
  • There is a deadzone in the middle of the screen for some reason where the flickable doesn't pick up flicks (invisible notification stealing maybe?)
  • Figure out how to get top indicators and time on top of the quicksettings panel when it's open (duplicating may cause some unintended consequences)

image

image

image

image

image

image

Edited Apr 09, 2021 by Devin Lin
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/rework-top-panel