Skip to content

WIP: Adapt toggleTorch code for PinePhone

Luca Weiss requested to merge lucaweiss/plasma-phone-components:pinephone-torch into master

Problems with this MR:

  • Breaks libhybris code
    • Would require checking of droidcamsrc existed and then have a path for libhybris and a path for proper Linux APIs
  • Hardcodes /dev/video1
    • Would require finding the correct node based on something?
  • Can't turn off torch, just on
    • would mean setting led_mode to 0 instead of 2
    • either make gstreamer do that when destroying the pipeline or manually?

Comments on how to best solve this are welcome :)

Merge request reports