Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Plasma Mobile Plasma Mobile
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 68
    • Issues 68
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma MobilePlasma Mobile
  • Merge requests
  • !62

WIP: Adapt toggleTorch code for PinePhone

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Luca Weiss requested to merge lucaweiss/plasma-phone-components:pinephone-torch into master Mar 19, 2020
  • Overview 10
  • Commits 1
  • Pipelines 0
  • Changes 1

Problems with this MR:

  • Breaks libhybris code
    • Would require checking of droidcamsrc existed and then have a path for libhybris and a path for proper Linux APIs
  • Hardcodes /dev/video1
    • Would require finding the correct node based on something?
  • Can't turn off torch, just on
    • would mean setting led_mode to 0 instead of 2
    • either make gstreamer do that when destroying the pipeline or manually?

Comments on how to best solve this are welcome :)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: pinephone-torch