Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma applet for NetworkManager
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • Plasma applet for NetworkManager
  • Merge requests
  • !109

Merged
Created Mar 31, 2022 by Nate Graham@ngrahamDeveloper

applet: port away from contextMenu and use contextualActionsModel

  • Overview 1
  • Commits 1
  • Pipelines 2
  • Changes 1

With changes to ExpandableListItem in frameworks/plasma-framework!491 (merged), we can now define both contextual actions and a custom content view. This means we can put the actions that are currently in the context menu in the contextual actions list instead, so they will be displayed in the expanded view above the custom content.

This yields several benefits:

  • Makes these items more consistent with other expandable list items in other widgets
  • Removes the use of a context menu, which goes against the purpose of this component (to be fully usable with only left-clicks or touches) and half of whose items were redundant
  • Removes a PlasmaComponents2 import
Before After
Before After

@teams/vdg @teams/usability

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: port-away-from-contextmenu-and-to-contextualactionsmodel