Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma applet for NetworkManager
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma applet for NetworkManager
  • Merge requests
  • !128

Don't forget to activate a connection if we show a dialog when activating

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Arjen Hiemstra requested to merge work/ahiemstra/addandactivate into master Jun 24, 2022
  • Overview 2
  • Commits 1
  • Pipelines 3
  • Changes 2

addAndActivate in some cases will show the connection editor dialog. In that case, once the dialog is confirmed, we would call "addConnection" rather than "addAndActivateConnection", so one would need to manually connect to the now correctly configured network again. Instead, move the "addAndActivate" dbus call to its own method so we can call it in the signal handler rather than calling only addConnection.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/ahiemstra/addandactivate