Skip to content

Remove UB parameter passing to va_list argument in OpenconnectAuthWorkerThread::openUri

OpenconnectAuthWorkerThread::openUri previously passed a UB nullptr argument to OpenconnectAuthWorkerThread::writeProgress. This can potential break builds for certain target ABIs. Similarly, passing a va_list that was not initialized with va_start/va_copy would be UB as well. This patch omits needing interact with the va_list argument by calling OpenconnectAuthStaticWrapper::writeProgress instead.

Fixes: 408cca64 ("Add support for openconnect_set_external_browser_callback introduced in openconnect v9.0 (libopenconnect 5.8) using QDesktopServices") Signed-off-by: Rahul Rameshbabu sergeantsagara@protonmail.com

Merge request reports