Skip to content

Port to KUrlRequester::setNameFilters

Prajna Sariputra requested to merge psariputra/plasma-nm:namefilters-port into master

Unlike !279 (closed) nameFilters does exist in KUrlRequester, and the filter does work:

image

Marked as draft since I have not requested approval for a string freeze exception yet just in case anyone has objections to the wording, in particular the two fields in the OpenVPN one that says "Local peer's private key in .pem format." confuses me since it uses the same set of file extensions as the "Certificate authority (CA) file in .pem format." field, can't tell if it's intentional or not.

Ideally we'd just have the filter show the extensions with no wording like how it was with KF5, but just using <string>*.der *.pem *.crt *.cer</string> or <string>(*.der *.pem *.crt *.cer)</string> unfortunately does not work, seems like that's actually a bug as per the discussion in frameworks/kio!1503 (merged) but if so I'm not sure whereabouts to report that.

With plasma-integration!128 (merged) nameless filters work again, so with that a string freeze approval is no longer required. Ideally then this MR should be merged after that one, but the worst that merging this first will do is to break the filter, but selecting files still works, and the compilation problem is still fixed either way.

Edited by Prajna Sariputra

Merge request reports

Loading