Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma PulseAudio Applet
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 15
    • Merge requests 15
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • Plasma PulseAudio Applet
  • Merge requests
  • !15

Correctly look up data in the model

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged David Redondo requested to merge work/davidre/appmenu into master Oct 15, 2020
  • Overview 0
  • Commits 1
  • Changes 1

Commit fbd66cdc exposed this preexisting bug. Before sModel was always a PlasmaCore.SortFilterModel but now that we can hit the !showHiddenDevices.visible condition in main.qml:546/573 it can also just be a normal SourceModel or SinkModel that do not have a get() method like the SortFilterModel. So we have to access the data properly. BUG:427687 FIXED-IN:5.20.1

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: work/davidre/appmenu