Skip to content

KCM: Fix QML warnings

Ismael Asensio requested to merge work/iasensio/fix-width-warning into master

Set the width binding of the delegate on the instance instead of in the component declaration.

This fixes a QML warning when the parent is temporarily not set in the delegate creation and is also slightly more efficient as the property is explicitly qualified

qrc:/kcm/kcm_pulseaudio/RenameDevices.qml:98:9: TypeError: Cannot read property 'width' of null
qrc:/kcm/kcm_pulseaudio/RenameDevices.qml:98:9: TypeError: Cannot read property 'width' of null
....

Also set a missing explicit argument in a signal handler:

qt.qml.context: qrc:/kcm/kcm_pulseaudio/DeviceListItem.qml:119:13 Parameter "index" is not declared. 
Injection of parameters into signal handlers is deprecated. Use JavaScript functions with formal 
parameters instead.

Merge request reports