Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma PulseAudio Applet
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 15
    • Merge requests 15
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma PulseAudio Applet
  • Merge requests
  • !3

Add "Balance" option for per-channel (e.g. left, right) volume sliders

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Kai Uwe Broulik requested to merge work/channel-volumes into master May 24, 2020
  • Overview 16
  • Commits 5
  • Pipelines 0
  • Changes 14

When checking the "Balance" button, a volume slider for each channel (e.g. left, right, center, subwoofer, etc) is shown.

When opening settings with different volumes in some of the channels, "Balance" is checked automatically.

Furthermore, when unchecking "Balance" again, all channels are set back to a uniform volume. Normally, plasma-pa adjusts volume by keeping the difference between channels in tact, so means of explicitly assigning all channels in one go is added.

Also, QQC2 Slider has an explicit onMoved signal which is only fired when the user explicitly moves the slider. This should remove the need for the convoluted "ignore changes" property dance that was present before.

Technically, we could also do per-channel volume for streams, which isn't done in this patch, as I am not sure how useful being able to play music on the left speaker and watching a video on the right is.

Screenshot_20200524_213305 Screenshot_20200524_213318Screenshot_20200524_213457 Latest iteration: Screenshot_20200527_173138

Edited May 27, 2020 by Kai Uwe Broulik
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/channel-volumes