Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma PulseAudio Applet
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 20
    • Merge requests 20
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma PulseAudio Applet
  • Merge requests
  • !32

[applet] Move tab bar to bottom

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Nate Graham requested to merge ngraham/plasma-pa:move-aplet-tabbar-to-bottom into master Dec 08, 2020
  • Overview 10
  • Commits 1
  • Pipelines 0
  • Changes 1

This switches the position of the current header and footer content, which allows the applet to have a toolbar in the header like most other applets have. As a result, the tab bar is moved to the footer.

BUG: 430121 FIXED-IN: 5.21

I'm not 100% satisfied with this since now we have two lines of toolbar icons which feels a little bit odd. But the bottom tab bar position feels a bit better.

The "mute all devices" button could be moved up to the header row without problems, but also adding the "show unused devices" button there would be problematic as it's not really appropriate.

Open to ideas.

Screenshot_20201208_082022

cc @teams/vdg

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: move-aplet-tabbar-to-bottom