Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma PulseAudio Applet
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 17
    • Merge requests 17
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma PulseAudio Applet
  • Merge requests
  • !5

Filter out currently unused devices

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nate Graham requested to merge work/ngraham/filter-out-useless-devices into master Jun 12, 2020
  • Overview 10
  • Commits 12
  • Pipelines 0
  • Changes 7

Right now devices that have only a single unplugged port are visible in the applet and the KCM. For all intents and purposes, these devices are useless as they are inactive and unused. Therefore, let's filter them out so they're not distracting and confusing to the user. An option to see them all again is provided in the KCM on the off chance that a person needs to configure the volume or balance of an unused device before it's used.

This patch is principally aimed at people using hardware where PulseAudio represents multiple input and output sources as separate devices rather than separate ports of the same device. I asked the PA people about this and they said that for certain hardware, it's intentional, and the correct approach is to filter out the unused devices over here [1]. So, that's what this patch does.

Thanks to @nicolasfella for his help with getting the initial prototype working!

BUG: 422612

FIXED-IN: 5.20

[1] https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/issues/913

Applet, before:

Insane

Applet, after:

Screenshot_20200613_202703

KCM, before:

Cluttered_and_useless

KCM: after:

vokoscreenNG-2020-06-11_17-51-37

Connecting a Bluetooth speaker adds it to both the applet and the KCM, and I can switch between it and the internal speakers with the radio buttons:

Screenshot_20200611_203800

Additionally connecting an HDMI television adds it as well, and switching between them works:

Screenshot_20200611_204031

cc @teams/vdg

Edited Jun 14, 2020 by Nate Graham
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/ngraham/filter-out-useless-devices