Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma PulseAudio Applet
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 17
    • Merge requests 17
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma PulseAudio Applet
  • Merge requests
  • !60

WIP: Add a Shift + Volume Mute hotkey that mutes only the default (selected) device

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Benjamin Xiao requested to merge bxiao/plasma-pa:mute_fix into master Apr 29, 2021
  • Overview 14
  • Commits 3
  • Pipelines 0
  • Changes 1

This is to address https://bugs.kde.org/show_bug.cgi?id=434217

Currently the default mute key behavior mutes all devices on a system. This does not align with other operating systems and is inconsistent with the mute behavior for the microphones. This patch adds a single device mute function and associates the mute a Shift + Volume Mute shortcut to it. It also adds a new GlobalAction so that users can configure a global mute shortcut if they so choose.

This patch is WIP as there is more things to address in the bug:

1.) I am not sure what the right way is to add a QKeySequence in QML. I want the default global mute shortcut to be Shift + Volume Mute, but currently I am only able to assign single keys. If anyone can help me with that it would be much appreciated.

2.) The bug report also addresses exposing a global mute icon in the widget. Currently there is actually a global mute icon, but it is hidden by default. I don't want to unhide it without understanding what the reasoning behind hiding it in the first place was.

3.) I want to fix the global mute behavior a bit more. Currently, on my system, sometimes devices will unmute themselves when attempting a global mute. In particular, Digital Output (S/PDIF Starship/Matisse HD Audio Controller) loves to unmute right after a global mute. When I attempt to global unmute, it fails to unmute all muted devices because the list of globally muted devices doesn't line up with what the plasma-pa widget is aware of and so it only does a single device unmute. This will be done in a separate patch.

Edited May 03, 2021 by Benjamin Xiao
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: mute_fix