Skip to content
  • Konrad Materka's avatar
    [XembedSNIProxy] Check size in each update() · acf91005
    Konrad Materka authored and Nate Graham's avatar Nate Graham committed
    Summary:
    If needed, perform resize in each update().
    Client window may be too big, it must be resized to a certain reasonable size. Sometimes resizing in the constructor is not enough because it is too early and the client window is not fully initialized. Even if client window is resized, on first update it reverts back to original size (or just ignores the first request - some kind of a race condition).
    
    In addition, I applied some rules from: https://community.kde.org/Policies/Kdelibs_Coding_Style
    
    BUG: 358240
    
    Test Plan:
    I tested it using keepass2, now it shows better results (still not perfect). Window is resized to 32x32, but icon is only 24x24 it top-left. Better than 273x273 with tiny dot in the corner. This is a workaround for unsolvable bug in Mono - AFAIK Windows Forms are not longer maintained so it won't be fixed.
    
    I tested this change with several other apps for regressions, no issues:
    pidgin
    liferea
    hexchat
    tuxguitar
    xchat
    keepassx
    stardict
    and other I don't remember now. No regressions.
    
    Reviewers: davidedmundson, #plasma, #plasma_workspaces, broulik
    
    Reviewed By: davidedmundson, #plasma, #plasma_workspaces
    
    Subscribers: broulik, plasma-devel
    
    Tags: #plasma
    
    Differential Revision: https://phabricator.kde.org/D24529
    acf91005