Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Workspace
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 111
    • Merge requests 111
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma Workspace
  • Merge requests
  • !119

[wallpapers/image] Look for wallpaper for the device's physical size

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Nate Graham requested to merge ngraham/plasma-workspace:set-correct-wallpaper-size-for-high-dpi into master Jun 27, 2020
  • Overview 18
  • Commits 1
  • Pipelines 0
  • Changes 1

When using PLASMA_USE_QT_SCALING=1, the sizes returned here are automatically scaled down to be the logical size, taking into account the scale factor. However this is not what we want; in this case, we want to choose a wallpaper that matches the screen's physical size, not its logical size, or else it will be too small and look blurry.

To accomplish this, we need to multiply the returned width and height values by the device pixel ratio. When using PLASMA_USE_QT_SCALING=1, this is set to the correct value, so multiplying by it will produce the correct final size.

BUG: 423563 FIXED-IN: 5.19.3

Edited Jun 29, 2020 by Nate Graham
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: set-correct-wallpaper-size-for-high-dpi