Skip to content

applets/notifications: re-implement critical notification line better

Nate Graham requested to merge ngraham/plasma-workspace:critical-notification-line-only-in-popup into master

Two commits which should not be squashed if this is merged

Author: Nate Graham <nate@kde.org>
Date:   Fri Nov 19 13:33:46 2021 -0700

    applets/notifications: re-implement critical notification line better
    
    This commit re-implements the critical notification to be inside the
    notification popup, not the notification item. This yields several
    benefits:
    - It's the semantically correct place to implement it since critical
      notifications don't appear in the history, so there's no reason to
      implement it in a component that's re-used for the history view
    - The line extends down to the bottom for critical notifications that
      have  buttons, job progress, text input fields, files, or screenshots
    - Simpler code overall
Author: Nate Graham <nate@kde.org>
Date:   Fri Nov 19 12:57:47 2021 -0700

    Revert "applets/notifications: Embellish header for critical notifications"
    
    This reverts commit be7efa5ec2bcf2c87947ee2ff5e2b9c70eb2084e.
    This reverts commit 93355636de136e99112a19a57deccbd2e8dfbd66.
    
    This was not the best way to implement the feature, as it failed to take
    into account the fact that critical notifications can have more content
    than just text. A better place to implement it would be in the popup
    itself.

cc @broulik

Edited by Nate Graham

Merge request reports