Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Workspace
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 19
    • Issues 19
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 102
    • Merge requests 102
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • Plasma Workspace
  • Merge requests
  • !1262

Merged
Created Dec 08, 2021 by David Edmundson@davidedmundsonDeveloper

[libtaskmanager] Increase buffer for pipewire format negotiation

  • Overview 1
  • Commits 1
  • Pipelines 6
  • Changes 1

Libtaskmanager's buffer for spa_builder is too small on certain configurations. Because podBuilder->state.offset is never reset, the buffer space can run out when EGL returns a long list of dma_buf modifiers, causing PipeWire negotiation to fail.

An example is when EGL returns 20 modifiers. There are 6 formats defined in pipewiresourcestream.cpp, for each format it will construct 2 frames, one with 218=168 bytes long of modifiers. The modifier lists for all frames will be 6168=1008 bytes (only 16 bytes left of 1024 bytes), let alone other frames.

BUG: 446061

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: work/pipewire_buffer