Skip to content

[applets/batterymonitor] Fit it, pt.12: Respect personal space

Apart from a bunch of minor refactoring this patch set fixes two layout bugs:

  1. Overflow of inhibition hints
  2. Collision of slider's labels
Language: EN
Before: Before_en
After: After_en
Language: RU
Before: Before_ru
After: After_ru

One thing that concerns me is that narrow applet with this collision fix looks like it uses available horizontal space inefficiently. Unfortunately, this is a fundamentally hard problem, no easy fix is available in modern Qt. Based on a discussion in VDG room, we'd rather drop the middle label, thus making more room for the other two.

After, EN (narrow)
After_en_narrow

Next up:

  • Fix the slider:
    • Drop middle tick's label, rework other two
    • Factor out the slider into a component of its own (with grayed out inhibited values support);
  • Flatten double column and revisit spacing in PowerManagementItem (especially after recent changes);
  • Factor out tons of syntax garbage because of (nullable ? nullable.properties || [access]) : [access]

Merge request reports

Loading