Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Workspace
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 19
    • Issues 19
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 110
    • Merge requests 110
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • Plasma Workspace
  • Merge requests
  • !1375

applets/batterymonitor: Improve text and icon if neither batteries nor brightness controls are present

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Fabian Vogt requested to merge work/fvogt/batteryicon3 into master Jan 18, 2022
  • Overview 3
  • Commits 2
  • Pipelines 6
  • Changes 1

f9e39815 ("applets/batterymonitor: Improve for desktop systems") changed the plasmoid to use a plain icon instead of the CompactRepresentation if there are no batteries. While 471cc374 ("applets/batterymonitor: fix CompactRepresentation") brought the use of the CompactRepresentation back, the plain icon is still used.

For the case that there are no batteries and brightness controls available, it fell back to "battery", which has no symbolic variant. Change that to use the symbolic "video-display-brightness" as well.

BUG: 448520

CC @apol @ngraham

Maybe it should just say "Power Management" in this case?

Plasma < 5.24.90:

Screenshot_20220118_230521

Plasma 5.24.90:

Screenshot_20220118_230616

This MR:

Screenshot_20220118_231605

Edited Jan 18, 2022 by Fabian Vogt
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: work/fvogt/batteryicon3