Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Workspace
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 19
    • Issues 19
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 110
    • Merge requests 110
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • Plasma Workspace
  • Merge requests
  • !1412

applets/notification: improve DND mode explanatory text

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Nate Graham requested to merge ngraham/plasma-workspace:less-puzzling-dnd-text into master Jan 27, 2022
  • Overview 12
  • Commits 1
  • Pipelines 2
  • Changes 1

This text suffered from two issues:

  • By trying to generate an English sentence, it became a string puzzle because not all possible relative date strings would work after the word "until". For example, "Until In two days" would be wrong.
  • It used inappropriate capitalization of the date despite trying to be in a sentence.

This commit fixes both issues by splitting the two parts of the text on either side of a colon, creating a logical break between them.

BUG: 421989 FIXED-IN: 5.25

cc @teams/vdg

Before After
Before After
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: less-puzzling-dnd-text