Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Workspace
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 18
    • Issues 18
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 95
    • Merge requests 95
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • Plasma Workspace
  • Merge requests
  • !1569

Merged
Created Mar 16, 2022 by Nate Graham@ngrahamDeveloper

Remove "Lock" and "logout" items from default desktop context menu

  • Overview 15
  • Commits 1
  • Pipelines 4
  • Changes 1

These items don't have anything to do with the desktop itself, so that's not really the right place for them, making it unlikely that anyone would expect to find them in the desktop context menu.

Instead, these items are probably there as a sort of emergency escape valve so that people can still lock the screen and log out under the following set of circumstances:

  1. They've accidentally removed their launcher menu or primary panel, or it has gotten lost due to multi-screen arrangement bugs
  2. ...And they don't know how to perform these actions from KRunner
  3. ...And they don't know the keyboard shortcuts for these actions

This seems very unlikely, given how we have made it much harder to accidentally remove your panel and its applets over time, how much robustness work we've put into multimonitor workflows, and how we now even have a UI to restore panels that have gotten lost anyway. So having these actions in the context menu specifically to protect against such an unlikely happenstance is therefore not worth it, and we can safely remove them by default (note that users can add them back) to unclutter the context menu and make it more relevant to the desktop itself.


There is no need to handle the now-orphaned menu separator as QMenu takes care of automaticlaly suppressing separators when they are the last item in the menu.

Desktop Context menu now:

Default_menu_now

cc @teams/vdg @teams/usability

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: remove-lock-and-logout-actions-from-the-context-menus