Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Workspace
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 19
    • Issues 19
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 110
    • Merge requests 110
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • Plasma Workspace
  • Merge requests
  • !170

[kcms/icons] Use OverlaySheet for icon size popup

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Nate Graham requested to merge ngraham/plasma-workspace:use-overlaysheet-for-icon-size-popup into master Jul 24, 2020
  • Overview 21
  • Commits 1
  • Changes 2

Right now it's a custom pop-up which does basically the same thing as a Kirigami OverlaySheet, but it does not use that component, so as a result it is visually inconsistent.

This commit ports it to use Kirigami.OverlaySheet, making whatever minor layout changes to the UI are necessary to make it fit well inside the sheet.

Everything still works including focus and arrow key handling.

cc @broulik @teams/vdg

Here's how it looks now:

Now_an_overlaysheet

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: use-overlaysheet-for-icon-size-popup